search

audeering / opensmile-python

Python package for openSMILE
https://audeering.github.io/opensmile-python/
Other
243 stars 32 forks source link

Fix gemaps family #18

Closed frankenjoe closed 3 years ago

frankenjoe commented 3 years ago

Will be released as v2.0.0.

codecov[bot] commented 3 years ago

Codecov Report

Merging #18 (7024f3e) into master (f2d0176) will not change coverage. The diff coverage is 100.0%.

Impacted Files Coverage Δ
opensmile/core/config.py 100.0% <100.0%> (ø)
opensmile/core/define.py 100.0% <100.0%> (ø)
opensmile/core/smile.py 100.0% <100.0%> (ø)
hagenw commented 3 years ago

Do we need first a new release of https://github.com/audeering/opensmile?

frankenjoe commented 3 years ago

In principle no, since only config files change, but not the binaries. But of course if we release this first it means we can extract feature sets with pyopensmile that are not yet available in opensmile. I leave this decision to @chausner-audeering.

chausner-audeering commented 3 years ago

Feel free to go ahead with this release.

frankenjoe commented 3 years ago

@chausner-audeering ok! Once you are done with your review please merge or assign back to me.

frankenjoe commented 3 years ago

Looks good overall. If not already done or part of the unit tests, we should probably do a manual test that the new feature set indeed works.

All feature sets are automatically tested against SMILExtract.