Correct field in output .wav file header

audeering / opensmile

The Munich Open-Source Large-Scale Multimedia Feature Extractor

https://audeering.github.io/opensmile/

Other

553 stars 74 forks source link

Correct field in output .wav file header #42

Closed ceqq closed 2 years ago

ceqq commented 2 years ago

For 32-bit float PCM WAV, AudioFormat (Compression type) field must contain 3 (IEEE float). Correct 2 files (waveSink.cpp, waveSinkCut.cpp): head.AudioFormat = sampleFormat == SMILE_SF_32BIT_FLOAT ? 3 : 1; // !!! ?? Otherwise the float wav files are misinterpreted by a number of programs. https://audiocoding.ru/articles/2008-05-22-wav-file-structure/wav_formats.txt Best regards Yevgueny

chausner-audeering commented 2 years ago

Thanks a lot for reporting this bug! I've fixed this in our internal version. We have planned to publish a new open-source release on GitHub in January which will include this fix and other improvements. Until then, I'll leave this issue open for now.

ceqq commented 2 years ago

Great! And nice to meet you. I've corrected it for myself in the local version, which is quite enough for me. Will report if find more. (I'm trying using it for 1-st day only, and with the current documentation it's necessary to read certain sources and test edge cases in detail.)

chausner-audeering commented 2 years ago

Version 3.0.1 has been released with a fix so I'll close this issue.