Add script for creating release archives

audeering / opensmile

The Munich Open-Source Large-Scale Multimedia Feature Extractor

https://audeering.github.io/opensmile/

Other

578 stars 75 forks source link

Add script for creating release archives #68

Closed hagenw closed 11 months ago

hagenw commented 11 months ago

This adds the script make_release.sh which generates all the needed archives for uploading on the github release page, when doing a new release.

There are a few differences compared to what we have at https://github.com/audeering/opensmile/releases/tag/v3.0.1:

libSMILEapi.so is now stored under lib/ as in the compiled package and not under bin/
all archives are stored as ZIP
the names of the archives differ and follow the names of the folders created in the CI job, e.g. opensmile-3.0.1-linux-armv7

hagenw commented 11 months ago

I'm not completely sure, why before both binaries were inside the bin/ folder. I looked at the documentation and there anyway only the executable is discussed anyway. So, I think it should be safe to add lib/ in addition to bin/ in the release archives. Or are there any expected relative paths?

Linux13524 commented 11 months ago

I'm not completely sure, why before both binaries were inside the bin/ folder. I looked at the documentation and there anyway only the executable is discussed anyway. So, I think it should be safe to add lib/ in addition to bin/ in the release archives. Or are there any expected relative paths?

I think they need to be in the same folder so the executable can find the library. Otherwise you would need to specify LD_LIBRARY_PATH or move the library into a system path. Not sure about Windows though.

For this reason I would still prefer to have it in the bin as it was before.

Linux13524 commented 11 months ago

It would be good to add set -e to exit when the first command fails.

hagenw commented 11 months ago

I'm not completely sure, why before both binaries were inside the bin/ folder. I looked at the documentation and there anyway only the executable is discussed anyway. So, I think it should be safe to add lib/ in addition to bin/ in the release archives. Or are there any expected relative paths?

I think they need to be in the same folder so the executable can find the library. Otherwise you would need to specify LD_LIBRARY_PATH or move the library into a system path. Not sure about Windows though.

For this reason I would still prefer to have it in the bin as it was before.

Thanks for the input, I copy now everything from lib/ to bin/ as well.

hagenw commented 11 months ago

It would be good to add set -e to exit when the first command fails.

Good idea (and wasn't aware of it), I added it