audiamus / AaxAudioConverter

Convert Audible aax files to mp3 and m4a/m4b
GNU General Public License v3.0
1.51k stars 115 forks source link

AAX aborts during conversion #191

Closed awchappell closed 1 year ago

awchappell commented 1 year ago

I have one book that consistently causes the program to abort. I have done the following.

I have attached a log file with 2 runs. Modes "Single file per AAX file" and "Multiple files split into shorter Tracks, ignoring chapters". I have converted over 40 books, using the "Multiple files split into shorter Tracks, ignoring chapters", per the provided jpg, with no problems.

Thanks for the help

aax_audio_converter_abort AaxAudioConverter_2023-09-20_001.zip

audiamus commented 1 year ago

According to the log file, something goes wrong while writing the meta data. I have to look it up in the code, but that will take a few days, I am currently on holidays.

awchappell commented 1 year ago

Enjoy your holiday.

Thanks.

On Thu, Sep 21, 2023, 12:36 audiamus @.***> wrote:

According to the log file, something goes wrong while writing the meta data. I have to look it up in the code, but that will take a few days, I am currently on holidays.

— Reply to this email directly, view it on GitHub https://github.com/audiamus/AaxAudioConverter/issues/191#issuecomment-1729926600, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6A2F5XTQSNX3T364ISESD3X3RUHHANCNFSM6AAAAAA5AWAEQM . You are receiving this because you authored the thread.Message ID: @.***>

audiamus commented 1 year ago

I have checked the source of the error message and it appears that this is related to the cover image. Could this me missing for your book?

awchappell commented 1 year ago

You are correct there is no cover image in the original .m4b. I added a cover image using Mp3tag. I then ran AAX converter and again it aborted, see attached log file. I was converting other files and came across another file that aborted, it also did not have a cover in the .m4b. The program does make the .mp3 files and places them in the correct folders, but no tags are filled in ie title, artist, year. AaxAudioConverter_2023-09-25_001.zip

audiamus commented 1 year ago

After more investigation:

The ArgumentException "Data should not be null and be at least 3 bytes long" from ATL can only be thrown in conjunction with invalid cover image data. It seems, some sort of cover image data is present, which prevents earlier safeguards to intercept further processing, but the image data is invalid.

I will add more error checking here to let the conversion continue.

awchappell commented 1 year ago

If there is anything I can do to help please let me know. If you want a copy of the "bad" files let know.

On Wed, Sep 27, 2023, 13:23 audiamus @.***> wrote:

After more investigation:

The ArgumentException "Data should not be null and be at least 3 bytes long" from ATL can only be thrown in conjunction with invalid cover image data. It seems, some sort of cover image data is present, which prevents earlier safeguards to intercept further processing, but the image data is invalid.

I will add more error checking here to let the conversion continue.

— Reply to this email directly, view it on GitHub https://github.com/audiamus/AaxAudioConverter/issues/191#issuecomment-1737800896, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6A2F5SP6G7BBCLTOFTJ7YDX4ROHRANCNFSM6AAAAAA5AWAEQM . You are receiving this because you authored the thread.Message ID: @.***>

audiamus commented 1 year ago

Try new version 1.18.2. It should no longer abort the conversion.

What actually might have gone wrong is that the book in question does have a few bytes of data for the cover image, but that data is invalid. And Mp3tag has some unexpected behavior. When adding an image, Mp3tag does not automatically remove the previous one. So the broken image may still have been there for your 2nd conversion attempt.

awchappell commented 1 year ago

You are correct there is no cover image in the original .m4b. I added a cover image using Mp3tag. I then ran AAX converter and again it aborted, see attached log file. I was converting other files and came across another file that aborted, it also did not have a cover in the .m4b. The program does make the .mp3 files and places them in the correct folders, but no tags are filled in ie title, artist, year. AaxAudioConverter_2023-09-25_001.zip

awchappell commented 1 year ago

Your update works! The 2 problem files convert with no abort. The .mp3 files have tags filled in and the cover is blank. Thank you for the update.

audiamus commented 1 year ago

Your update works!

Very good.