So I Can split this PR: but this is the feedback I have working so-far...
[X] Separated runtime and dev dependencies (it actually seems like in this case it makes zero difference, but it's good practice)
[X] add a linting script
[X] Remove the alias for build (just use npm run build)
[X] Add some guard clauses
[X] Add some tests (looks like the current structure is a bit hard to test)
[X] Extract root component separate from Analytics bindings, CSS (outer-edge)
[X] Remove console.log call(s)
[X] Move & Guard setState call(s) (not ideal)
I Could split this into multiple PR's and do a bit at a time as right now these are mostly Frontend presentation tests and they don't cover most of the important detail.
[ ] Test isolated libs separately
[ ] Isolate some Component code that should be library & add tests
[ ] Re-structure components to avoid mounting issues during re-render for tests. (Redux stores instead of state might be an approach here)
So I Can split this PR: but this is the feedback I have working so-far...
build
(just usenpm run build
)I Could split this into multiple PR's and do a bit at a time as right now these are mostly Frontend presentation tests and they don't cover most of the important detail.