search

audiconnect / audi_connect_ha

Adds an audi connect integration to home assistant
MIT License
238 stars 97 forks source link

style: Update audi_models.py #268

Closed Ingrimmsch93 closed 8 months ago

Ingrimmsch93 commented 8 months ago

removed unnecessary comma and streamlined formatting

Kolbi commented 8 months ago

mmh Pre-Commit recently added them... https://github.com/Kolbi/audi_connect_ha/commit/7fda643bdb9d99deb243acdbcb2b6eb633a61b30#diff-decdc50a875cd0173e621453749b6838d5611866684bda843a9194cb7717732d

Ingrimmsch93 commented 8 months ago

This precommit was done by a bot, right? I don't get why some lines stayed in one line without extra comma and other where split over multiple lines with extra comma. I am not experienced enough to tell if it could be a problem.

Kolbi commented 8 months ago

Yes a bot.

Funny thing: https://github.com/arjenvrh/audi_connect_ha/pull/269/commits/9f56ba34b726b5acf28cdf6fd848280b61518e50 to be honest I currently don't know why some fields are formatted in multiple lines and some in a single line... maybe because of the length.

Need to dig deeper into ruff-format.

cdnninja commented 8 months ago

Most likely a length thing.

cdnninja commented 8 months ago

Now that the pre-commit is working looks like this can be closed as it un does ruff.