search

audiconnect / audi_connect_ha

Adds an audi connect integration to home assistant
MIT License
227 stars 98 forks source link

fix: Any Window Open w/ Unsupported Sunroof #371

Closed coreywillwhat closed 5 months ago

coreywillwhat commented 5 months ago

Allows for unsupported window state for the sunRoof. I haven't had a chance to test this yet with my car. I will do that later today. @Kolbi if you get a chance to test on yours that would be great.

Kolbi commented 5 months ago

Seems not to work.

Kolbi commented 5 months ago

I guess starting point needs to be here? https://github.com/audiconnect/audi_connect_ha/blob/d4470877d4e4481df0326da564c797ea46610469/custom_components/audiconnect/audi_models.py#L398 as STATE_SUN_ROOF_MOTOR_COVER is not generated because of unsupported.

coreywillwhat commented 5 months ago

ah okay, right, we can default to None then I think

coreywillwhat commented 5 months ago

give it a shot again if you have a chance. I have to jump on some calls. If that doesn't work, I can test/work on it in a few hours.

coreywillwhat commented 5 months ago

Tested and the updated code is still working for me.

cdnninja commented 5 months ago

give it a shot again if you have a chance. I have to jump on some calls. If that doesn't work, I can test/work on it in a few hours.

I will leave this one for @Kolbi to review and merge.

Kolbi commented 5 months ago

Tested and working :) Thanks @coreywillwhat