search

audiconnect / audi_connect_ha

Adds an audi connect integration to home assistant
MIT License
224 stars 98 forks source link

fix: charging_complete_time #402

Closed Kolbi closed 4 months ago

Kolbi commented 4 months ago

Like discussed in https://github.com/audiconnect/audi_connect_ha/issues/401 we always set remaining_charging_time to at least 0 in https://github.com/audiconnect/audi_connect_ha/blob/5055bc34b14e99fda066ce9975da9e8c98ee99da/custom_components/audiconnect/audi_connect_account.py#L1655

coreywillwhat commented 4 months ago

The current state of this PR would incorrectly make the charging_complete_time sensor unavailable for an electric vehicle when the remaining_charging_time hits 0. This would remove the sensors ability to state the timestamp in the past, that the vehicle completed charging.

We should leave this sensor as is, and instead address the remaining_charging_time sensor. If remaining charging time isn't available or is unsupported, it should be set to None instead of 0.

If we use that method, then the charging complete time will not pass the support check and will not display for the user either so solves the gas vehicle issue while not removing functionality of the existing sensors.

I can work on a PR for this when I have time if thats okay with you @Kolbi

Kolbi commented 4 months ago

The current state of this PR would incorrectly make the charging_complete_time sensor unavailable for an electric vehicle when the remaining_charging_time hits 0. This would remove the sensors ability to state the timestamp in the past, that the vehicle completed charging.

We should leave this sensor as is, and instead address the remaining_charging_time sensor. If remaining charging time isn't available or is unsupported, it should be set to None instead of 0.

If we use that method, then the charging complete time will not pass the support check and will not display for the user either so solves the gas vehicle issue while not removing functionality of the existing sensors.

I can work on a PR for this when I have time if thats okay with you @Kolbi

Feel free to contribute to this PR. Hadn't the time to do it.

coreywillwhat commented 4 months ago

408 for this fix