audiconnect / audi_connect_ha

Adds an audi connect integration to home assistant
MIT License
224 stars 98 forks source link

Add target soc percent "targetSOC_pct" for e-tron #404

Closed epweston closed 4 months ago

epweston commented 4 months ago

First, thank you so much for everyone's work on this project.

I would love to be able to read the target charge value and was hoping "targetSOC_pct" under "chargingSettings" could be added. Let me know if I did not supply enough information.

Thank you

Kolbi commented 4 months ago

Can you please attach a log file? The return value from the API would be enough if you don't want to attach the whole file. Which etron do you own?

epweston commented 4 months ago

Yes, and we have the:

Q4 e-tron® Premium 50 e-tron® quattro® (2023)

home-assistant_audiconnect_2024-04-19T22-01-02.814Z.log

Thanks

Kolbi commented 4 months ago

Hi added this PR, do you have the possibility to test it?

mpredfearn commented 4 months ago

Maybe it would be worth adding this as a "number" entity in case the API that the App uses to change it becomes known?

Kolbi commented 4 months ago

Maybe it would be worth adding this as a "number" entity in case the API that the App uses to change it becomes known?

Sorry I didn't got your point. :) Can you explain it a little bit more?

mpredfearn commented 4 months ago

https://github.com/audiconnect/audi_connect_ha/pull/405 adds "target SoC" as a sensor suggesting it is read only. The app is able to update this, it is read write, so a "number" entity would be more appropriate.

epweston commented 4 months ago

Hi added this PR, do you have the possibility to test it?

Sure np, can I just replace certain files in config\custom_components\audiconnect and restart HA, if so, where to I find the file(s)? Or do I wait for the releases? Thanks in advance.

Kolbi commented 4 months ago

https://github.com/audiconnect/audi_connect_ha/pull/405 adds "target SoC" as a sensor suggesting it is read only. The app is able to update this, it is read write, so a "number" entity would be more appropriate.

I got your point. Need to check it tomorrow.

coreywillwhat commented 4 months ago

The Target SOC sensor should read the current state of the vehicle as provided by the API. Sensors are by nature unchangeable and are just readings from the device/vehicle/API. I haven't tested, but #405 looks like it meets the requirement of a target SOC sensor.

An input_number entity would only make sense as a control, but then we would need to figure out the service call to set the target SOC and then update that input_number based on the API response and As far as I know, at this time, the service call to set the charger/target SOC of the vehicle is not working due to the API changes and I haven't had time to work on it. I also dont have the ability to set the charger (PHEV) which makes it difficult to test.

@mpredfearn are you able to use the audi connect execute vehicle action to start charging/set target SOC currently?

mpredfearn commented 4 months ago

@coreywillwhat I was suggesting a "number" entity which can be RW, not an "input_number" which is WO to the user. Perhaps a sensor combined with a service call for updating it is more in line with the rest of this integration, but most other integrations I have use the different entity types to implement this kind of behaviour.

Unfortunately I am unable to test - my e-tron 55 is a 2019 model before Audi implemented the remote setting of the target charge limit - mine is adjustable from the MMI only :-/

Kolbi commented 4 months ago

@mpredfearn as long as we do not have an API to test & set the Target SOC - I would say implement it as RO for the moment.

I openend a new "issue" for implementing Number: https://github.com/audiconnect/audi_connect_ha/issues/412

epweston commented 4 months ago

Just applied the 1.7.0 update today and it is working great! Thanks you!