audiconnect / audi_connect_ha

Adds an audi connect integration to home assistant
MIT License
215 stars 99 forks source link

FR: Include light(s) status by `vehicleLights` node. #421

Open mm98 opened 2 months ago

mm98 commented 2 months ago

Is your feature request related to a problem? Please describe. My car returns the light status for left and right. This information also exist in the JSON (from debug logs)

"vehicleLights": {
    "lightsStatus": {
        "value": {
            "carCapturedTimestamp": "datetime.datetime",
            "lights": [
                {
                    "name": "right",
                    "status": "off"
                },
                {
                    "name": "left",
                    "status": "off"
                }
            ]
        }
    }
}

Describe the solution you'd like Would it be possible to include these two values as sensors in this integration?

Describe alternatives you've considered No alternatives.

Additional context This information is also visible in the MyAudi app. As shown below: image

Logfile home-assistant_audiconnect_2024-04-29T07-19-42.831Z.log

Your Vehicle Details Model: A5 Sportback advanced 40 TFSI S tronic Year: 2021 Type (ICE/PHEV/BEV): ICE

coreywillwhat commented 2 months ago

thanks @mm98 . Great suggestion! I'm guessing these are in reference to the interior lights? Have you tested by chance? If not I can give it a go.

mm98 commented 2 months ago

thanks @mm98 . Great suggestion! I'm guessing these are in reference to the interior lights? Have you tested by chance? If not I can give it a go.

Your guess is as good as mine 😄 left and right doesn't really make any sense in regard to external light (front or back). I haven't tested myself yet, since I just noticed these in the myAudi app. All the checkmarks in the screenshot above is all for external "things", so i would guess - it is front left and right (bulb maybe)? I don't have any light inside for left and/or right.

mm98 commented 2 months ago

I just tested by turning on the ignition. Turned light off and use fog light. Nothing changed with the light status in the myAudi app.

My interior lights are static. Not something I can affect or change in any way.

image

Audi's response is actually wrong. My front left window wasn't open, but only the front left door. If I can do anything else to help debug, please let me know! I'll gladly help, if I can.

cdnninja commented 2 months ago

Could left right lights be euro park lights? Where you park the car with your blinker enabled on one side. It then keeps that side on for the duration of parking.

This is typically disabled in NA.

A guess though.

mm98 commented 2 months ago

Could left right lights be euro park lights?

I'll do some testing with park lights and get back to you with more info!

mm98 commented 2 months ago

I can confirm it is parking lights. Car parked with turn indicator on for left.

image

image

coreywillwhat commented 2 months ago

Thanks for testing @mm98 ! I'm thinking the best method for this would be a single binary sensor for All Lights with attributes for each light. Let me know what you think.

mm98 commented 2 months ago

Let me know what you think.

I agree. No reason to have them separate.

github-actions[bot] commented 4 weeks ago

This issue is stale because it has been open for 45 days with no activity. Are you still experiencing this issue?

coreywillwhat commented 4 weeks ago

Bump