Properly rename core_osx.so to core.so for mac builds

issuebotaudinowho[bot] commented 11 months ago

Discord: traio#0 <@467050112787677184>

Bug Report:

upon booting up PMDO on Mac, it uses core.so instead of core_osx.so for debugging

audinowho commented 11 months ago

This also happens with x86 debugging since there's a conflict with core_x86.dll as well.

Possible fixes:

Change the lua search path based on the platform when loading debugger. Will need to find out how to do this.
Rename all core.dll to core_x64.dll and core.so to core_linux.so, and rename them back as a build step. This will need to be for both debugging and release building. This will result in some build steps referencing. Less preferred, but possible if the above option doesnt work.
Do the above, but instead of renaming during build time, rename during runtime. Even less preferred but possible if the above option doesnt work.

Current lua search path (windows):

NLua.Exceptions.LuaScriptException
  HResult=0x80131500
  Message=...\PMDODump\DumpAsset\Data/Script/lib/socket.lua:12: module 'socket.core' not found:
    no field package.preload['socket.core']
    no file '~\PMDODump\PMDC\PMDC\bin\x64\Debug\net6.0\lua\socket\core.lua'
    no file '~\PMDODump\PMDC\PMDC\bin\x64\Debug\net6.0\lua\socket\core\init.lua'
    no file '~\PMDODump\PMDC\PMDC\bin\x64\Debug\net6.0\socket\core.lua'
    no file '~\PMDODump\PMDC\PMDC\bin\x64\Debug\net6.0\socket\core\init.lua'
    no file '~\PMDODump\PMDC\PMDC\bin\x64\Debug\net6.0\..\share\lua\5.4\socket\core.lua'
    no file '~\PMDODump\PMDC\PMDC\bin\x64\Debug\net6.0\..\share\lua\5.4\socket\core\init.lua'
    no file '.\socket\core.lua'
    no file '.\socket\core\init.lua'
    no file '~\PMDODump\DumpAsset\Data/Script/lib/socket\core.lua'
    no file '~\PMDODump\DumpAsset\Data/Script/socket\core.lua'
    no file '~\PMDODump\DumpAsset\Data/Script/socket\core/init.lua'
    no file '~\PMDODump\PMDC\PMDC\bin\x64\Debug\net6.0\socket\core.dll'
    no file '~\PMDODump\PMDC\PMDC\bin\x64\Debug\net6.0\..\lib\lua\5.4\socket\core.dll'
    no file '~\PMDODump\PMDC\PMDC\bin\x64\Debug\net6.0\loadall.dll'
    no file '.\socket\core.dll'
    no file '~\PMDODump\DumpAsset\Data\Script\bin\socket\core.dll'
    no file '~\PMDODump\PMDC\PMDC\bin\x64\Debug\net6.0\socket.dll'
    no file '~\PMDODump\PMDC\PMDC\bin\x64\Debug\net6.0\..\lib\lua\5.4\socket.dll'
    no file '~\PMDODump\PMDC\PMDC\bin\x64\Debug\net6.0\loadall.dll'
    no file '.\socket.dll'
    no file '~\PMDODump\DumpAsset\Data\Script\bin\socket.dll'
  Source=
  StackTrace:
   at NLua.Lua.ThrowExceptionFromError(Int32 oldTop) in ~\PMDODump\PMDC\RogueEssence\NLua\src\Lua.cs:line 367

audinowho commented 10 months ago

https://github.com/RogueCollab/RogueEssence/commit/489b3ca2338ce124d52647d0f4f19a29b15375ac

audinowho / PMDODump

Properly rename core_osx.so to core.so for mac builds #405