Hidden Ability removed on middle stage

audinowho / PMDODump

All content generation for PMDO. BEWARE SPOILERS.

MIT License

63 stars 13 forks source link

Hidden Ability removed on middle stage #478

Closed issuebotaudinowho[bot] closed 4 days ago

issuebotaudinowho[bot] commented 6 months ago

Discord: shitpost_sunkern#0 <@292039958829727744>

Bug: Pokémon whose middle stage has no Hidden Ability cannot evolve into the final stage with a Hidden Ability. According to Bulbapedia, it should be possible to evolve to the Hidden Ability

https://discord.com/channels/534207185333256223/575891034949812225/1232073074980032543

audinowho commented 6 months ago

This one requires re-architecting the way abilities are handled to be slot based rather than ID based. Making that change may also be disadvantageous in other ways, so this one may need to be let go.

435THz commented 2 months ago

Maybe not... We could add a slot value on Character initialization instead. The slot would be inferred by the ID of the ability, or randomized if the ability is not a valid one for the Pokémon's form. Then, on evolution, whe have these two cases to worry about:

If the slot number exceeds the amount of abilities the new form has, choose one of the others at random
If the slot number does not exceed the amount, assign the one in that slot

This would require changes only in the evolution method, right?

435THz commented 2 months ago

PR https://github.com/RogueCollab/RogueEssence/pull/122 offers a solution