search

audinowho / PMDODump

All content generation for PMDO. BEWARE SPOILERS.
MIT License
62 stars 13 forks source link

Differentiate formes in Guide #57

Open issuebotaudinowho[bot] opened 2 years ago

issuebotaudinowho[bot] commented 2 years ago

Discord: Shitpost Sunkern#8311 <@292039958829727744>

Oh, and while we're at it, the guide doesn't list Alolan Vulpix separately from normal, but it probably should

audinowho commented 2 years ago

The starting point will be to change the Dictionary Key type from integer (just the dex number) to MonsterID or similar-functioning tuple, and then rewrite code to adjust to that type change. https://github.com/PMDCollab/PMDC/blob/1c509fc50074e5f34ba68b5dfd69d4bc74c8e4d6/PMDC/Dev/StrategyGuide.cs#L298

Currently has several ambiguities that make this a non-trivial task; particularly in determining whether a specific form of a specific mon can be obtained via evolution. Currently the evolution check code checks the pokedex just to see if it has a pre-evolution, and that pre-evo is obtainable. It does not check to see if the pre-evolution has the same form as the chosen dex entry, and does not account if that form would evolve into the current form.