search

audiodude / rainfall

Bandcamp exodus solution, letting you create personal artist sites using Faircamp
https://rainfall.dev
MIT License
12 stars 0 forks source link

Workaround to allow spaces in release and song names (for now) #48

Closed audiodude closed 1 month ago

audiodude commented 1 month ago

As stated in #46, we can't reliably and conclusively represent all possible song titles in a ext4 file name. However, as a compromise, we create our own version of secure_filename that doesn't replace ' ' with '_'. This should cover the most common cases, though accents, umlauts, emoji and the like will all still get stripped.

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.80%. Comparing base (6d62a49) to head (d42e401).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #48 +/- ## ========================================== + Coverage 95.79% 95.80% +0.01% ========================================== Files 30 30 Lines 2021 2027 +6 ========================================== + Hits 1936 1942 +6 Misses 85 85 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

audiodude commented 1 month ago

Note that when this gets released, I will need to log into the production server and do a one time migration (rename_all_sites.py) to update the existing paths.