search

audiohacked / OpenCorsairLink

Linux and Mac OS support for the CorsairLink Devices
GNU General Public License v2.0
705 stars 125 forks source link

corsairlink_commanderpro_set_fan_connection_mode() un-used #240

Open simplesomeone opened 4 years ago

simplesomeone commented 4 years ago

This is more of a question than an actual issue. Why is the corsairlink_commanderpro_set_fan_connection_mode function in https://github.com/audiohacked/OpenCorsairLink/blob/testing/protocol/commanderpro/fan.c#L310 unused?

It seems important. In my specific scenario, we have fans that are coming out as set to "auto" and at 100% PWM, reach 4500RPMs. But the fans are rated for upwards of 12,000RPMs. My suspicion is that it's this mode setting, and it needs to be "4-pin" instead. But this function is not used at all.

Thanks for any help.

simplesomeone commented 4 years ago

We (my company) has our own fork of this repistory. I added a fan.profile.write_profile driver to run that function with the 0x02 "4-pin" setting. That resolved the issue.

For anyone wondering why your fans are not running at full power, it needs to be 4-pin, not AUTO!

simplesomeone commented 4 years ago

I guess I'll leave this issue open in case anyone wants to submit an official fix. I unfortunately do not have time at this moment. Maybe in the future I will.