search

audiojs / audio-play

Play audio buffer in browser/node
MIT License
60 stars 14 forks source link

Please package pre-compiled version #16

Closed peterbe closed 6 years ago

peterbe commented 6 years ago

I use create-react-app and one of my dependencies is audio-play. Sadly I can't build my create-react-app due to this error:

▶ yarn build
yarn run v1.6.0
$ react-scripts build
Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file:

    ./node_modules/audio-play/browser.js:16

As per their instructions to resolve this it says

"Open an issue on the dependency's issue tracker and ask that the package be published pre-compiled."

So can we please have a pre-compiled version within the package?

latel commented 6 years ago

same problems here, it's hard to play babel 7

derhuerst commented 6 years ago

Do you know why it doesn't minify/compile?

dy commented 6 years ago

@latel @peterbe try 2.2.1 - that has ES5 code. Tested that with uglifyjs - works fine. If that does not help, the problem is not in this package.

peterbe commented 6 years ago

It works! I'm using audio-loader and audio-play and now I can run yarn run build in my create-react-app project. Thanks!