search

audiolion / apistar-jwt

A JSON Web Token Component for API Star
MIT License
41 stars 8 forks source link

Missing PyJWT in setup.py? #1

Closed mblayman closed 7 years ago

mblayman commented 7 years ago

Hi, @audiolion. I noticed your project on the Discuss site so I thought I'd check it out. I see that the code calls import jwt, but I don't see PyJWT as a dependency in setup.py. Am I missing something?

Thanks for you efforts so far. I look forward to a time where API Star has a robust 3rd party ecosystem.

audiolion commented 7 years ago

Oh great catch! Had it in my Pipfile and forgot to put it in there

https://github.com/audiolion/apistar-jwt/blob/5bcfd26bc35fcf9d8f380d5e6df1f843fb7c1fed/Pipfile#L6-L9

audiolion commented 7 years ago

Already Alrighty* made a new release on PyPI 0.1.2

mblayman commented 7 years ago

Cool! FYI, I've maintained a bunch of packages in the past and have had a lot of success using tox since it's designed to test packages. It tends to shake out any packaging bugs.

audiolion commented 7 years ago

Yeah I actually haven't gotten the tests up yet, I have used tox in the past but only because I was testing across a bunch of python versions, but since API Star is 3.5+ only I didn't feel the need, also I wasn't sure how to get tox to work with pipenv, if you want to submit a PR to get tox working with it though it would be appreciated!