search

audiolize / vagrant-softlayer

This is a Vagrant plugin that adds a SoftLayer provider to Vagrant, allowing Vagrant to control and provision SoftLayer CCI instances.
MIT License
42 stars 15 forks source link

0.3.2 proposed #20

Closed ju2wheels closed 9 years ago

ju2wheels commented 9 years ago
  1. Specifying vlans by name
  2. force_private_ip
  3. docs
  4. contrib tools
  5. Vagrant Cloud
  6. Critical bug fix in action handler logic/variable use that closes #19

Let me know if 6 is too much for this one and ill drop it but given the impact to the core actions, I added it.

That leaves everything from parallel builds on forward remaining for the next release(s) you set.

emyl commented 9 years ago

I've merged your work, but I still have a doubt about #19. Could you explain me the exact steps to reproduce the bug?

ju2wheels commented 9 years ago

Create any working Vagrantfile that should work ok on vagrant up then ensure you havent actually built the machine yet and run vagrant destroy.

The specific bug is here:

  1. b.use used where b2.use should be in destroy block : This causes the entire state check to be skipped and it goes straight on to deleting an instance that doesnt exist.
  2. same as above in rebuild
  3. The rest of the changes are just to ensure the box is actually there before trying to decide whether the action needs to be taken so it outputs the appropriate message (modeled after upstream providers)
emyl commented 9 years ago

Ok figured it out. Thanks.

But I've fixed it in a different way, 3. looks redundant to me.

ju2wheels commented 9 years ago

Upstream has 3. refactored out into a separate vm exists action. We can look at reducing that overall code reuse that way.

[edit]Noticed it was drop, ignore.