audioscience / avdecc-lib

Simple C++ library for implementing IEEE1722.1 (AVB Device Enumeration, Discovery and Control)
MIT License
79 stars 45 forks source link

view details doesn't use index correctly #109

Closed andrew-elder closed 10 years ago

andrew-elder commented 10 years ago

cmd_line::cmd_view_details() calls cmd_line::do_view_descriptor() which doesn’t take account of the entity ID passed into the view details command. Whoops!

andrew-elder commented 10 years ago

Any objects to a slight change to the cmdline syntax for "view details". We currently have view details [index | GUID] which does not work.

I'd like to propose we change that to view details where the entity "view" is set via select [index |GUID] entity_index configuration_index.

Would this break anything for any users?

pthedinger commented 10 years ago

Sounds ok to me. Won't break anything for us.

andrew-elder commented 10 years ago

Thanks Peter. You were the main party I wanted to hear back from!


From: "Peter Hedinger" notifications@github.com Sent: Wednesday, September 03, 2014 3:04 AM To: "audioscience/avdecc-lib" avdecc-lib@noreply.github.com Cc: "andrew-elder" aelder@audioscience.com Subject: Re: [avdecc-lib] view details doesn't use index correctly (#109)

Sounds ok to me. Won't break anything for us.

Reply to this email directly or view it on GitHub.