search

audioxide / website

The Audioxide website, made with Vue
https://audioxide.com
GNU Affero General Public License v3.0
0 stars 0 forks source link

[DNM] Newsletter label issue fix #130

Closed frederickobrien closed 3 years ago

frederickobrien commented 3 years ago

Lighthouse flagged an accessibility with the new newsletter component. Oddly the thing it says isn't there is there so need to look at this more closely with fresh eyes.

andrewbridge commented 3 years ago

I believe it might be because the input doesn't have a name attribute

frederickobrien commented 3 years ago

I believe it might be because the input doesn't have a name attribute

Line 22, no? Really not sure what Lighthouse's beef is here, the code it says is missing is there.

andrewbridge commented 3 years ago

I believe it might be because the input doesn't have a name attribute

Line 22, no? Really not sure what Lighthouse's beef is here, the code it says is missing is there.

Ah I missed that the attribute was there, you're right. But the for attribute on the label is looking for mce-EMAIL and the name attribute is just EMAIL

andrewbridge commented 3 years ago

I think that should fix it @frederickobrien, I'll defer to you as you know exactly what issue you were fixing initially!

frederickobrien commented 3 years ago

Lighthouse no longer flags this as an issue so I've closed this. I think we're good.