search

audioxide / website

The Audioxide website, made with Vue
https://audioxide.com
GNU Affero General Public License v3.0
0 stars 0 forks source link

[DNM] 404 page #143

Closed frederickobrien closed 1 month ago

frederickobrien commented 3 years ago

Features/tweaks done:

andrewbridge commented 3 years ago

This all looks good, would be good to know more about that theme colour meta as per above and then we can work out what's going on. Otherwise this is good to go.

frederickobrien commented 3 years ago

This all looks good, would be good to know more about that theme colour meta as per above and then we can work out what's going on. Otherwise this is good to go.

Ok, I've added aria labels to the external link icon so we should be good to go there. I actually set up this PR with a 404 page in mind but I haven't got my head around that yet. Maybe worth waving this through if it looks ok to you and I'll come at that problem afresh later?

frederickobrien commented 3 years ago

Ok, I stopped umming and ahing and had a go at a custom 404 page for when a URL does not exist. Some success but have of course hit a wall. Hard to tell if this is a Netlify issue or a Vue issue as the bleed between the two here makes the documentation of both less useful than I would like.

What do you reckon, @andrewbridge?

andrewbridge commented 3 years ago

@frederickobrien with your couple follow up commits following your previous message, you've got there on the Netlify side. If you run the build on your local machine, you'll be able to see the 404/index.html file that you're now pointing to.

With Nuxt, however, it's a bit more involved. The docs actually suggest using a layout called error.vue. The one thing I've neglected to do as well is to implement the validate method, which would instruct Nuxt to show the error page if a page or post didn't exist in our data.

I'm a bit torn, because what you've done provides a statically generated 404 page, which I think is pretty important, but it won't play entirely nicely with Nuxt. There may be a middle ground that can give us the benefits of both. I'll can take a look some time this week if you're still hitting a dead end.

frederickobrien commented 3 years ago

The code is sound, but I still had the old ribbons locally (and no badge) so had to swap them. I think that's why the build is failing for now.

andrewbridge commented 3 years ago

@frederickobrien think it's because in setup.js we specifically copy files prefixed with ribbon-. We could add a check for badge- as well.

Incidentally, what's with the lock files in https://github.com/audioxide/website/pull/143/commits/b4fec106ad430aece3df426a9c7fb6244587dfff ?

frederickobrien commented 3 years ago

@frederickobrien think it's because in setup.js we specifically copy files prefixed with ribbon-. We could add a check for badge- as well.

Incidentally, what's with the lock files in b4fec10 ?

I guess it makes sense to have a universal prefix, be it ribbon-, badge-, award-, or whatever else?

Aha, I downloaded some stuff for Scala and it seems to have worked its way into the branch somehow. 'Metals' is the Scala plugin for VSC. Sorry, wasn't sure what to do about that one.

frederickobrien commented 3 years ago

I've updated setup.js, @andrewbridge, and changed all award files to start with award-. Deploy still fails, hits a stumbling block with the new format. Do PRs pull from the main brand repo? If so that may be where the issue is? I've added the new ribbon/sticker files there and kept the old ones for now as not to break the current site.

I've also done a quick fix for the banner issue Gabs mentioned! Not the most elegant solution but the perfect is the enemy of the good, etc.

frederickobrien commented 3 years ago

Do you think it'd be worth retracting the 404 changes for now and merging the rest of this, @andrewbridge? Would be nice to get the cosmetic tweaks integrated. Lesson learned also: I'll make my PRs even smaller from now on. Almost nothing to be gained from bundling even two or three things together.

frederickobrien commented 3 years ago

Ok, I've redone all commits apart from the 404 page and new ribbons as separate PRs. Once the brand repo is rebased and I know the new awards work ok I'll move them over too.

frederickobrien commented 1 month ago

This will be included in https://github.com/audioxide/website/pull/183