andrewbridge
commented
2 years ago You were totally right to remove all the dependencies and to modify setup.js in 0b35c195cba013f1fe2a6fc4cf30666b743d8d40.
What broke the build was that by removing this line, which is a file copy from licensed-assets to our codebase. By removing that line without the whole file copy call, it told the script to copy non-existent files to undefined (I'd guess ¯_(ツ)_/¯). That stopped the script running the other file copies from our brand repo and that meant things like our logo didn't exist and Nuxt choked.
I've backtracked on your backtrack and just removed the full file copy and it's looking good!
This PR is part of an ongoing effort to make all assets Audioxide uses open source/fair use. We've already addressed fonts - this takes care of icons. Where before we were using Font Awesome now have SVGs from open source libraries - mainly Remix. It doesn't always look as pretty but it's a starting point. Once all our repos are public we can get back to making them better.
Some examples of what these changes look like. (Not picture: random article loading brain and external link symbol on artwork stories.)
Some of your lovely animations/changes on hover are gone for now, @andrewbridge, sorry. We'll get them back eventually! Having our own little library of icon SVGs should be quite nice going forward, and their shapes can updated with relative ease without having to reconfigure the whole setup.
The final step - which I think is better suited to a third PR - is to remove any need for the private licensed-assets repo. Although all our assets will be fair game once this is merged the repo is still where our fonts live. These should either be moved into brand or website.