search

audit4j / audit4j-core

An open source auditing framework.
http://audit4j.org
Apache License 2.0
125 stars 77 forks source link

Library is not thread safe #19

Closed theborakompanioni closed 8 years ago

theborakompanioni commented 8 years ago

Since you are looping over all handlers and set the AuditEvent for the each of them.. it is possible to lose events - the library is therefore not thread safe. See AuditEventProcessor L70 https://github.com/audit4j/audit4j-core/blob/master/src/main/java/org/audit4j/core/AuditEventProcessor.java#L70

janithb commented 8 years ago

Audit4j framework based on reactor pattern to process events asynchronously. Hence all the processing based on single event loop which runs on a single thread but still serve the high performance processing. I don't see any issue ass long as handling exceptions properly. What do you think?

theborakompanioni commented 8 years ago

Ahh! Ok, that's nice. I have just looked at the processor level. Thank you.