search

audit4j / audit4j-core

An open source auditing framework.
http://audit4j.org
Apache License 2.0
126 stars 76 forks source link

correctly detects java versions above java 8 #94

Closed pauldambra closed 3 years ago

pauldambra commented 4 years ago

Here's a possible solution to #85

The java version checker called for the system property directly which made it hard to test so I've pulled that behaviour separate to the EnvUtils that contained it and inject the system property

This let me write parameterised tests to check a range of java versions.

I spotted that EnvUtil.getJavaVersion was (I'm assuming) typoed as EnvUtil.getJavaersion so fixed that too.

pauldambra commented 4 years ago

felt bad about renaming the method and realised why.... subconscious was worried about breaking somebody else's code unexpectedly since it's a public method.

Have instead deprecated it so both getJavaersion and getJavaVersion are available

pauldambra commented 4 years ago

@janithb it would be great to get this merged.... happy to make changes if you don't want to merge as is

yuyuchen09 commented 3 years ago

Thank you for the merge! Are you going to merge other PRs, and do a public release?

ramuwso2 commented 2 years ago

HI @janithb

I need may application to be upgraded to java 11. But because of this issue, im unable to do this.

Can you please let me know when will it be released? or any other alternative solution for this?