Old sodium-native causing compilation issues in Patchwork

auditdrivencrypto / secret-handshake

Mutually authenticating key agreement handshake

MIT License

202 stars 29 forks source link

Closed christianbundy closed 5 years ago

christianbundy commented 5 years ago

It looks like https://github.com/auditdrivencrypto/secret-handshake/commit/4682fe1a5caad405d406419b09a9b2844ddb4015 added sodium-native@1.x.x whereas we use sodium-native@2.x.x throughout the rest of the stack, which is currently breaking the build on Windows.

@dominictarr I don't see where sodium-native is being used, can it be removed from package.json?

cryptix commented 5 years ago

if it was on purpose, there should have been an explanation on the commit msg at least.

dominictarr commented 5 years ago

this is fixed in 1.1.18