audo-ai / magic-mic

Open Source Noise Cancellation App for Virtual Meetings
https://magicmic.ai/
352 stars 38 forks source link

Auto setup modules in pipesource-mvp #12

Closed gabcoh closed 3 years ago

gabcoh commented 3 years ago

Get pipesource-mvp to automatically load the requried pusleaudio modules and clean them up on start and stop

gabcoh commented 3 years ago

I have loading working, but not unloading. It's a little tricky because generally cleaning things up cleanly is not working right now, so once I figure out what's going on and have control over the lifecycle of the app, I should be able have this all implmented. But tbh, not sure if this is really worth working that much on if its just going to be superseeded by the custom module.

gabcoh commented 3 years ago

blocked on #13

gabcoh commented 3 years ago

This should be fixed with #13

It's a little inconsistent sometimes for some reason. Sometimes it will take 2 runs (but usually no more) to load the module. Either investigate this further or just let it try to load the module a few times within the app and don't fail if loading fails once.