search

audo-ai / magic-mic

Open Source Noise Cancellation App for Virtual Meetings
https://magicmic.ai/
352 stars 38 forks source link

Improve RPC #44

Closed gabcoh closed 3 years ago

gabcoh commented 3 years ago

Right now the rpc interface is pretty confusing, brittle and poorly documented. I want to improve it. Right now I'm sort of using JSON-RPC but not really. I don't support concurrent/asynchronous requests and it's very prone to race conditions. The methods are poorly documented. I'd like to fix all of this in as easy a way as possible which would probably mean sticking mostly with the current implementation, but I'm definitely on the look out for a tiny rpc framework that would make this easier. That said, I do think that fixing these issues probably won't be too hard with the current implementation.

gabcoh commented 3 years ago

I think it might actually be simpler (and sufficiently performant for now because we don't have any slow rpc methods) if the server supports concurrent requests just by dispatching them to the virtualmic one at a time rather than as they come in.