audreyfeldroy / cookiecutter-pypackage

Cookiecutter template for a Python package.
BSD 3-Clause "New" or "Revised" License
4.26k stars 1.78k forks source link

Invoking make clean fails #199

Closed coleslaw481 closed 8 years ago

coleslaw481 commented 8 years ago

Date used: 6-7-2016 8:50PM PST cookiecutter version: 1.4.0 python version: 2.7.10

Description

Invoking make clean from a source tree generated with this cookiecutter-pypackage template results in an error.

Here is the output:

$ make clean
clean-build clean-pyc clean-test
make: clean-build: No such file or directory
make: *** [clean] Error 1

Looks like the dependencies for the clean target were accidentally put in the command part of the target.

What I Did

$ cookiecutter https://github.com/audreyr/cookiecutter-pypackage
Cloning into 'cookiecutter-pypackage'...
remote: Counting objects: 1659, done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 1659 (delta 4), reused 0 (delta 0), pack-reused 1649
Receiving objects: 100% (1659/1659), 251.97 KiB | 398.00 KiB/s, done.
Resolving deltas: 100% (969/969), done.
Checking connectivity... done.
full_name [Audrey Roy Greenfeld]: bob smith
email [aroy@alum.mit.edu]: bob@bob.com
github_username [audreyr]: joe
project_name [Python Boilerplate]: foo
project_slug [foo]: 
project_short_description [Python Boilerplate contains all the boilerplate you need to create a Python package.]: 
pypi_username [joe]: 
version [0.1.0]: 
use_pytest [n]: 
use_pypi_deployment_with_travis [y]: 
Select command_line_interface:
1 - Click
2 - No command-line interface
Choose from 1, 2 [1]: 
create_author_file [y]: 
Select open_source_license:
1 - MIT license
2 - BSD license
3 - ISC license
4 - Apache Software License 2.0
5 - GNU General Public License v3
6 - Not open source
Choose from 1, 2, 3, 4, 5, 6 [1]: 
$ cd foo
$ make clean
clean-build clean-pyc clean-test
make: clean-build: No such file or directory
make: *** [clean] Error 1
mjscosta commented 8 years ago

I confirm the bug, and the fix!

audreyfeldroy commented 8 years ago

Thanks @coleslaw481 and @mjscosta. Fixed in #200 👍