search

audreyt / ethercalc

Node.js port of Multi-user SocialCalc
https://ethercalc.net
Other
2.96k stars 537 forks source link

Duplicate code/files #250

Open pjrobertson opened 8 years ago

pjrobertson commented 8 years ago

I'm making a few more changes to the codebase, and am trying to get my head around the code again...

It seems that a lot of code is duplicated in numerous places, and it's difficult for a beginner to the codebase to understand what's where.

For example, SocialCalcModule.js, socialcalcspreadsheetcontrol.js and src/player.ls all contain similar/the same code. I see that SocialCalcModule.js is a compiled file, as is static/ethercalc.js. Shouldn't these files be removed from the git repo?

I have create a PR (#249) that removes these files, but thought I'd open an issue to discuss it, and see if any other files can be removed from git.

audreyt commented 8 years ago

Well cat is Unix-specific (line 47 of Makefile) and so is make — if we can make everything runnable without build-essentials and on Windows (i.e. depending only on Node.js) then I'm all for removing the intermediate files and putting them into .gitignore.

pjrobertson commented 8 years ago

Aaah I see, so the requirement for all the files is for Windows.

In that case, I think we should probably move to use the convention of storing intermediates in a 'build' directory.

On 13 October 2015 at 11:20, 唐鳳 notifications@github.com wrote:

Well cat is Unix-specific (line 47 of Makefile) and so is make — if we can make everything runnable without build-essentials and on Windows (i.e. depending only on Node.js) then I'm all for removing the intermediate files and putting them into .gitignore.

— Reply to this email directly or view it on GitHub https://github.com/audreyt/ethercalc/issues/250#issuecomment-147583876.

audreyt commented 8 years ago

Exactly — Please feel free to amend the PR to make it so :-)