audreyt / ethercalc

Node.js port of Multi-user SocialCalc
https://ethercalc.net
Other
2.97k stars 538 forks source link

Fix build system #781

Open herve0742 opened 2 years ago

herve0742 commented 2 years ago

8380bd3

From a master clone, after npm i launching make run npm i --dev then node app.js --cors launching the server. Everything is correct except that each time I run make again, it always runs npm i --dev.

b94d176

Once the file static/ethercalc.js removed, while using node 12 or newer, make try to uglify and fails. But if I launch more times make, instead of re-trying to uglify, it never does and launch the server. Connecting to it succeed but creating new page or open existing one result in a "TypeError: SocialCalc.Sheet is undefined" JavaScript exception in the browser like audreyt/ethercalc#729. And ethercalc.js contains only one comment.

5b30fb5

Newer npm store more metadata.

82ce485

Like earlier, once the file static/ethercalc.js removed, while using node 12 or newer, make try to uglify and fails with the same error as audreyt/ethercalc#777. But running the same command with node v10 success and warn about deprecated function util.error. So this last commit update uglify-js, adapt option in Makefile and embed ethercalc.js and .map as the newer uglify uglifies differently the same source files.