Use :crlf layer with text files for new signatures

audreyt / module-signature

Module signature file manipulation

http://github.com/audreyt/module-signature

16 stars 28 forks source link

Use :crlf layer with text files for new signatures #21

Closed niklasholm closed 6 years ago

niklasholm commented 6 years ago

Fix for RT#126938

Setting the binmode layer to ':crlf' seems to do what we want correctly on all platforms. Detect and retain old behavior for old SIGNATURE files so they don't fail verification, but remove Win32 special case since it causes verification failure of some modules.

Other changes:

Set SHA256 as default hash since SHA1 is deprecated.
Add --strip-trailing-cr to 'diff' call.

audreyt commented 6 years ago

Thanks! Released as Module::Signature 0.82.

(I've moved the require version; into an eval {} block for Perl 5.005 compability.)

niklasholm commented 6 years ago

Nice! Although I forgot to change the version in META.yml,