Resolve compiler warnings on Node v7

audreyt / node-webworker-threads

Lightweight Web Worker API implementation with native threads

https://npmjs.org/package/webworker-threads

Other

2.3k stars 149 forks source link

Closed davisjam closed 7 years ago

davisjam commented 7 years ago

Whatever V8 is behind Node v7.4.0 deprecated some V8 methods, so switch to Nan where needed.

This resolves #135.

All tests pass just as well as they did before.

Bonus: In a few places I eliminated redundancy in the use of v8::Locker. I can break this out into a separate PR if you want.

davisjam commented 7 years ago

Oops, still learning some GitHub stuff. I didn't realize subsequent changes on the branch would show up here. I'll open a new PR tomorrow.

davisjam commented 7 years ago

See #139