search

audrl1010 / SlideMenuController

iOS Slide Menu Controller. It is written in pure swift.
MIT License
40 stars 13 forks source link

This is very useful library. but when setMain(viewController:), it do… #3

Open oslover opened 6 years ago

oslover commented 6 years ago

This is very useful library. but when setMain(viewController:), it doesn't remove the tapGesture, so after a new Main View controller is shown, user is unable to tap on the main view. Therefore, in animateMainViewController, we need to remove Tap Gesture. or in setMain method.

audrl1010 commented 6 years ago

Thank you for your interest in my project . (currentSlideOutState! = .main) in case, It should be a tapGesture of mainContainerView. The reason is (currentSlideOutState! = .main) in this case so that when the user taps the mainViewContainer, it will return to main. Therefore, you do not have to process it in the animationViewController method.

oslover commented 6 years ago

Thank you for your reply. but i actually experienced that it was not able to tap the tableviewcell in the mainview after the mainview was shown. i was only possible to tap the cell by second tap even after the mainview had already covered the whole iphone screen. it means the tapgesture was not removed by the moment. so i removed the tapgesture in the animateMainViewController method. and then, after i changed the code, i could tap the tableviewcell by first touch after the mainview appeared in the iphone screen. Therefore, if you don't like to add the code in animateMainViewController method, i think we need to remove the tap gesture somewhere else. I hope you test it by yourself. i think it's kinda serious problem.

oslover commented 6 years ago

PS: it works fine if mainview is already set in the appdelegate, but not work only when the mainview is newly set by setMain(method) by selecting any item in the leftView.

audrl1010 commented 6 years ago

Temporarily blocked tap on source. The reason is to prevent continuous tap.