aufacicenta / pulsemarkets

pulsemarkets-v2-web.vercel.app
1 stars 3 forks source link

feat: add cron job #200

Closed Udit-takkar closed 1 year ago

Udit-takkar commented 1 year ago

Fixes: https://github.com/aufacicenta/pulsemarkets/issues/157 Fixes: https://github.com/aufacicenta/pulsemarkets/issues/202

vercel[bot] commented 1 year ago

@Udit-takkar is attempting to deploy a commit to the Aufacicenta Team on Vercel.

A member of the Team first needs to authorize it.

Udit-takkar commented 1 year ago

@netpoe any update or feedback?

netpoe commented 1 year ago

@netpoe any update or feedback?

@Udit-takkar I merged your latest changes to this one and 3 tests fail:

failures:

---- tests::tests::err_self_destruct_unresolved stdout ----
note: panic did not contain expected string
      panic message: `"called `Result::unwrap()` on an `Err` value: HostError(GuestPanic { panic_msg: \"ERR_NO_OUTCOME_IDS\" })"`,
 expected substring: `"ERR_SELF_DESTRUCT_FEES_UNCLAIMED"`

failures:
    tests::tests::err_self_destruct_unresolved
    tests::tests::self_destruct_resolved_no_players
    tests::tests::sell_resolved

test result: FAILED. 10 passed; 3 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

error: test failed, to rerun pass `--lib`

Would you like to attempt and fix them? I can add another 100 USDT to the bounty for extending tests.rs to account for these additional errors introduced in self_destruct.

Udit-takkar commented 1 year ago

@netpoe okay fixed all the tests. Although not sure if this is how i should solve this

Screenshot 2023-10-27 at 12 06 11 AM
netpoe commented 1 year ago

@Udit-takkar I cannot push to your branch so please merge this branch: aufacicenta:udit-takkar into yours: Udit-takkar:feat/cron-jobs. I made some fixes and refactors to account for this cronjob feature. But lets keep the changes in this PR 👍

Udit-takkar commented 1 year ago

@netpoe done.

netpoe commented 1 year ago

@netpoe done.

Tests pass. Let me update the Factory contracts, deploy and test the cronjob. Give me a few days. Thx for your patience.

netpoe commented 1 year ago

@Udit-takkar https://explorer.testnet.near.org/transactions/41DCiMsUxHG4Z8De9HEXo3Kdxui5zCGdxtDTWF7PGgQT I've deployed the market-factory with the self_destruct updates. We need to wait for 7 days to test the cronjob on the most recent games.

I'll go ahead and merge this to avoid conflicts on potential changes.

I have your payment in mind. Don't worry.

Udit-takkar commented 1 year ago

@netpoe ok.

just confirming did you add CRON_API_KEY in secrets and .env file and APP_URL in secrets ?

netpoe commented 1 year ago

@netpoe ok.

just confirming did you add CRON_API_KEY in secrets and .env file and APP_URL in secrets ?

Not yet. But I'll keep an eye on the GH Actions logs.

Udit-takkar commented 11 months ago

@Udit-takkar https://explorer.testnet.near.org/transactions/41DCiMsUxHG4Z8De9HEXo3Kdxui5zCGdxtDTWF7PGgQT I've deployed the market-factory with the self_destruct updates. We need to wait for 7 days to test the cronjob on the most recent games.

I'll go ahead and merge this to avoid conflicts on potential changes.

I have your payment in mind. Don't worry.

@netpoe any update on this?

netpoe commented 11 months ago

@Udit-takkar https://explorer.testnet.near.org/transactions/41DCiMsUxHG4Z8De9HEXo3Kdxui5zCGdxtDTWF7PGgQT I've deployed the market-factory with the self_destruct updates. We need to wait for 7 days to test the cronjob on the most recent games. I'll go ahead and merge this to avoid conflicts on potential changes. I have your payment in mind. Don't worry.

@netpoe any update on this?

I tested by calling the ´self-destruct´ endpoint manually, before activating the cron job. I know the cron-job will work, but I need to make sure that the contracts are actually self-destroyed, which in this case, they weren't. Even with the latest updates we did to the Rust logic.

Udit-takkar commented 11 months ago

I tested by calling the ´self-destruct´ endpoint manually, before activating the cron job. I know the cron-job will work, but I need to make sure that the contracts are actually self-destroyed, which in this case, they weren't. Even with the latest updates we did to the Rust logic.

Okay do you see anything wrong in app/src/pages/api/cron/self-destruct.ts ? or any other error that were logged while testing

netpoe commented 11 months ago

I tested by calling the ´self-destruct´ endpoint manually, before activating the cron job. I know the cron-job will work, but I need to make sure that the contracts are actually self-destroyed, which in this case, they weren't. Even with the latest updates we did to the Rust logic.

Okay do you see anything wrong in app/src/pages/api/cron/self-destruct.ts ? or any other error that were logged while testing

Yes. While testing, I get errors of contracts with the old ´self_destruct´ logic. Since we are moving away from NEAR, I prefer not to invest much time into these Rust issues. Otherwise, I'd need to deploy a new NEAR market factory, etc.