search

auge8472 / My-Little-Forum-1

My Little Forum 1 is a thread based forum with additional board and nested views
GNU General Public License v2.0
6 stars 2 forks source link

RFC: Decoding [msg=] BBcode for mail #53

Open bttrx opened 4 years ago

bttrx commented 4 years ago

Hi!

currently posting text As mentioned in [msg=16101]IMPORTANT: Forum migration in November 2019[/msg] version 1.7.8 lacks full UTF-8 support. will be rendered to As mentioned in IMPORTANT: Forum migration in November 2019 --> 16101 version 1.7.8 lacks full UTF-8 support.

Please notice the 16101. That should be a clickable link to the posting. So mlf should place the correct URL to the forum in front of as in "Link to the entry: ...". Either take it from mlf's default view or the user's default view.

I have no idea for the IMPORTANT: Forum migration in November 2019 part. Maybe enclose in " or [] to make it stand out from normal message text?

Robert

auge8472 commented 4 years ago

This looks like the output, that should be created for e-mails. You see this when you open the posting in the web browser?

bttrx commented 4 years ago

Yes, it's the output for mails. Sorry, I didn't finish my first sentence in the initial posting before clicking "Submit new issue".

So, what I like to say is: "16101" is just plain text. No link to anywhere. It should be something like https://[...]/forum/forum_entry.php?id=16101 instead.

auge8472 commented 4 years ago

That's, like it works since ever and yes, the proposed behaviour is the preferable behaviour.

edit: to make it more clear, if you add a link to a posting, that contains a complete URL, you get a working URL in the e-mail. When Alex added the bb-code msg, the change wasn't adapted to the function unbbcode, where the posting text get prepared for the output in an e-mail.

bttrx commented 4 years ago

That's, like it works since ever

Yes. I were not clear enough, that this is not a new bug.

if you add a link to a posting, that contains a complete URL, you get a working URL in the e-mail

You mean, [msg=url]text[/msg] is also valid? Never tried that before.