search

augmentmy-world / arStudio

A innovative Web editor for Augmented Reality
https://webarstudio.tripod-digital.co.nz
MIT License
53 stars 34 forks source link

add nft trackables #17

Closed ThorstenBux closed 4 years ago

ThorstenBux commented 4 years ago

This PR add a Basic loading mechanism for NFT markers. For now It is possible to load only predefined markers: Pinball and maybe other from the dropdown menu.

To be tested and confirmed.

kalwalt commented 4 years ago

I will test this tomorrow as i have a bit of time. But reading the code i think that it should be ok. :slightly_smiling_face:

ThorstenBux commented 4 years ago

did you test it @kalwalt ?

kalwalt commented 4 years ago

@ThorstenBux I'm testing now. i will let you know soon :smile:

kalwalt commented 4 years ago

I can confirm that the NFT marker is added and is tracked! :1st_place_medal: :tada: :smile: Next step is adding the worker, If you want i can try to add this feature.

kalwalt commented 4 years ago

But before doing this maybe it will be better to switch to the minified version of the libs as for now we are using artoolkit.api.js and artoolkit.debug.js libs see here:

https://github.com/augmentmy-world/arStudio/blob/2604e6a2094f48409459e07e9d55ffbd7b73eb06/editor/index.html#L29-L30

as reported in this issue #7

ThorstenBux commented 4 years ago

Yes please if you can add both. I’ll do the custom upload of trackables and work on deploying it

Get Outlook for iOShttps://aka.ms/o0ukef

From: Walter Perdan notifications@github.com Sent: Tuesday, February 4, 2020 11:58:29 AM To: augmentmy-world/arStudio arStudio@noreply.github.com Cc: Thorsten Bux thorsten.bux@outlook.com; Mention mention@noreply.github.com Subject: Re: [augmentmy-world/arStudio] add nft trackables (#17)

But before doing this maybe it will be better to switch to the minified version of the libs as for now we are using artoolkit.api.js and artoolkit.debug.js libs see here:

https://github.com/augmentmy-world/arStudio/blob/2604e6a2094f48409459e07e9d55ffbd7b73eb06/editor/index.html#L29-L30https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faugmentmy-world%2FarStudio%2Fblob%2F2604e6a2094f48409459e07e9d55ffbd7b73eb06%2Feditor%2Findex.html%23L29-L30&data=02%7C01%7C%7C7dbab03892c04328074e08d7a8fc9672%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637163675113074982&sdata=23qZrBEa%2B%2BB5vs3Rw0t3q%2BbfZdllW73Z3zLn8QjJRE0%3D&reserved=0

as reported in this issue #7https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faugmentmy-world%2FarStudio%2Fissues%2F7&data=02%7C01%7C%7C7dbab03892c04328074e08d7a8fc9672%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637163675113084981&sdata=cN0X8cNsuYBEAE80VwI96r5G22juMtaOg1NOCN72zrQ%3D&reserved=0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faugmentmy-world%2FarStudio%2Fpull%2F17%3Femail_source%3Dnotifications%26email_token%3DAD765PBFBV4OZWQSD4PRKBLRBCORLA5CNFSM4KO3TWOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKVW3ZA%23issuecomment-581660132&data=02%7C01%7C%7C7dbab03892c04328074e08d7a8fc9672%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637163675113095004&sdata=1%2FUrSe7eGVCKfjA6HQ0ChM06D5hmwZXj2XOlR4yv0%2BU%3D&reserved=0, or unsubscribehttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD765PA5MTJADX3IV43AF43RBCORLANCNFSM4KO3TWOA&data=02%7C01%7C%7C7dbab03892c04328074e08d7a8fc9672%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637163675113105009&sdata=e6WRGgBas8N%2BWIou%2BEp%2BBHYFghheTepN4IlMyJ7PPUY%3D&reserved=0.

kalwalt commented 4 years ago

ok so we can merge also both PR i think.