augmentmy-world / arStudio

A innovative Web editor for Augmented Reality
https://webarstudio.tripod-digital.co.nz
MIT License
53 stars 34 forks source link

Rendering video frame #27

Closed kalwalt closed 4 years ago

kalwalt commented 4 years ago

@itamayo We continue the discussion started from this comment https://github.com/augmentmy-world/arStudio/issues/23#issuecomment-597725175 Can you elaborate a bit more if you can and when you have time, maybe referencing to the code? Thank you! :slightly_smiling_face:

itamayo commented 4 years ago

Basically it is about encompassing everything in the same canvas (video and webgl). For this, a 3d plane can be created as a texture for the video and it is inserted in the 3d world. Example for 3d plane and video (I have done without threejs). https://threejs.org/examples/#webgl_materials_video To improve jsartoolkit processing it be useful use this technique since it can adjust FPS of processing data. Soon as I have enough time , I would like to implemented this approach in this project as a branch show we can test it.

kalwalt commented 4 years ago

Thank you @itamayo interesting approach, if you need some help or support for jsartoolkit5 and arStudio just ask, you are welcome! :smile:

itamayo commented 4 years ago

I've been working a bit, it will take me longer than I expected since I'm trying to understand how is built "litegl" to do it. At least, I already have video rendering on the plane, let's see how it goes ...

kalwalt commented 4 years ago

@itamayo arStudio is built on top of litescene.js but some part of the code use litegl.js as you said, maybe Three.js is easier but i think you can do the same things with litescene.js. If you need help just ping me or @ThorstenBux .

itamayo commented 4 years ago

I have some problem with the shader but It works. Graphs is not my background, any help @kalwalt ? Screenshot from 2020-03-17 14-34-16

I did a pull request for new branch ...

kalwalt commented 4 years ago

Wow! @itamayo That is awesome! what do you mean for Graphs is not my background,? I will review and test your PR.

itamayo commented 4 years ago

i mean that I am not expert of graphics manipulation =)

On Tuesday, 17 March 2020, Walter Perdan notifications@github.com wrote:

Wow! @itamayo https://github.com/itamayo That is awesome! what do you mean for Graphs is not my background,?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/augmentmy-world/arStudio/issues/27#issuecomment-600079730, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4QT6EVROIYRDS7XAMR6Y3RH55HDANCNFSM4LLBJ3KA .

kalwalt commented 4 years ago

I mean that I am not expert of graphics manipulation =)

Don't worry the important thing is the solution!

ThorstenBux commented 4 years ago

Fixed with https://github.com/augmentmy-world/arStudio/pull/28