search

augmentmy-world / artoolkitX.js

8 stars 2 forks source link

issue with getCameraMatrix() #14

Open kalwalt opened 5 years ago

kalwalt commented 5 years ago

Actually the getCameraMatrix() https://github.com/augmentmy-world/artoolkitX.js/blob/a06cb356a9c22dc5bd16a8b79137f506592afbfa/Source/artoolkitX.api.js#L412-L414 call the exported function _arwGetProjectionMatrix but we have already a getProjectionMatrix in ARX_additions.js https://github.com/augmentmy-world/artoolkitx/blob/3710b8236efb629c30bb189a3e9d7e196a00662e/Source/artoolkitx.js/ARX_additions.js#L12-L23 Maybe we should use this?

kalwalt commented 5 years ago

should be: 

ARController.prototype.getCameraMatrix = function (nearPlane, farPlane) {
        return artoolkitXjs.getProjectionMatrix(nearPlane, farPlane);
    };

Does it correct?

kalwalt commented 5 years ago

Discussed here: #23 see the comments in the code review. I wil remove the function from ARX_additions.js because already in artoolkitX.api.js