search

augoisms / hubitat

MIT License
14 stars 13 forks source link

Changed Logging Preference to Hubitat Driver Standard txtEnable #17

Closed ucdscott closed 2 years ago

ucdscott commented 2 years ago

Replaced loggingEnabled with txtEnable to conform with built-in drivers and consolidate Hubitat Preference Manager entries for better user experience

lgkahn commented 2 years ago

Replaced loggingEnabled with txtEnable to conform with built-in drivers and consolidate Hubitat Preference Manager entries for better user experience

This is obsolete so mo longer maintained. Get the new version.

ucdscott commented 2 years ago

Where can I find the new version?

lgkahn commented 2 years ago

hubitat package manager or on the thread on the hubitat website.. search form sendmail v3

---- Original Message ---- From: "ucdscott" @.> Sent: 10/7/2022 2:52:59 PM To: "augoisms/hubitat" @.> Cc: "lgkahn" @.>, "Comment" @.> Subject: Re: [augoisms/hubitat] Changed Logging Preference to Hubitat Driver Standard txtEnable (PR #17)

Where can I find the new version? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

augoisms commented 2 years ago

@ucdscott @lgkahn This driver is not obsolete.

You can find the current version here: https://github.com/augoisms/hubitat/blob/master/rainforest-eagle/rainforest-eagle.driver.groovy

@ucdscott Regarding the PR. This driver doesn't support descriptive text logging. Descriptive text logging is different than the type of logging that this driver uses, which is more of the "debug" kind. If there is a universal consensus for a debug logging parameter I'll consider updating all my drivers.

ucdscott commented 2 years ago

The native Hubitat drivers use 'Enable debug logging' (name:logEnable) for debug logs.

lgkahn commented 2 years ago

thats not a driver i wrote.. 

---- Original Message ---- From: "Justin Walker" @.> Sent: 10/7/2022 3:04:00 PM To: "augoisms/hubitat" @.> Cc: "lgkahn" @.>, "Mention" @.> Subject: Re: [augoisms/hubitat] Changed Logging Preference to Hubitat Driver Standard txtEnable (PR #17)

@ucdscott @lgkahn This driver is not obsolete. You can find the current version here: https://github.com/augoisms/hubitat/blob/master/rainforest-eagle/rainforest-eagle.driver.groovy @ucdscott Regarding the PR. This driver doesn't support descriptive text logging. Descriptive text logging is different than the type of logging that this driver uses, which is more of the "debug" kind. If there is a universal consensus for a debug logging parameter I'll consider updating all my drivers. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

ucdscott commented 2 years ago

@lgkahn It appears you're responding on the incorrect thread. I submitted similar pull requests to both you and augoisms.