Use marshmallow for failsave json unmarshal

[nanu-c]

Type of change

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

Description

IMPORTANT TO KNOW

This can be tested now via Swagger for example on /webhooks/vivawallet/success/ with this sample JSON code

{
  "CorrelationId": "string",
  "Created": "2006-01-02T15:04:05Z",
  "Delay": "string",
  "newParameter": "string",
  "EventData": {
    "acquirerApproved": true,
    "amount": 0,
    "assignedMerchantUsers": [
      "string"
    ],
    "assignedResellerUsers": [
      "string"
    ],
    "authorizationID": "string",
    "bankID": "string",
    "billID": "string",
    "binID": 0,
    "cardCountryCode": "string",
    "cardExpirationDate": "string",
    "cardIssuingBank": "string",
    "cardNumber": "string",
    "cardToken": "string",
    "cardTypeID": 0,
    "cardUniqueReference": "string",
    "channelID": "string",
    "clearanceDate": "string",
    "companyName": "string",
    "companyTitle": "string",
    "connectedAccountID": "string",
    "currencyCode": "string",
    "currentInstallment": 0,
    "customerTrns": "string",
    "digitalWalletID": "string",
    "dualMessage": true,
    "electronicCommerceIndicator": "string",
    "email": "string",
    "externalTransactionID": "string",
    "fullName": "string",
    "insDate": "string",
    "isManualRefund": true,
    "latitude": "string",
    "longitude": "string",
    "loyaltyTriggered": true,
    "merchantCategoryCode": 0,
    "merchantID": "string",
    "merchantTrns": "string",
    "moto": true,
    "orderCode": 0,
    "orderCulture": "string",
    "orderServiceID": 0,
    "panEntryMode": "string",
    "parentID": "string",
    "phone": "string",
    "productID": "string",
    "redeemedAmount": 0,
    "referenceNumber": 0,
    "resellerCompanyName": "string",
    "resellerID": "string",
    "resellerSourceAddress": "string",
    "resellerSourceCode": "string",
    "resellerSourceName": "string",
    "responseCode": "string",
    "responseEventID": "string",
    "retrievalReferenceNumber": "string",
    "serviceID": "string",
    "sourceCode": "string",
    "sourceName": "string",
    "statusID": "string",
    "switching": true,
    "systemic": true,
    "tags": [
      "string"
    ],
    "targetPersonID": "string",
    "targetWalletID": "string",
    "terminalID": 0,
    "tipAmount": 0,
    "totalFee": 0,
    "totalInstallments": 0,
    "transactionID": "string",
    "transactionTypeID": 0,
    "ucaf": "string"
  },
  "EventTypeId": 0,
  "MessageId": "string",
  "MessageTypeId": 0,
  "RecipientId": "string",
  "Url": "string"
}

CHANGES

• Use marshmallow for fail-save json unmarshaling when receiving VivaWallet responses within function
• Improve ReadJSON function to handle unknown parameters or parameters that are given in struct but not submitted in JSON request
• Tested all three options in several POST-request by adding an unknown field, removing a field, whch can lead to an error if it used or not and by sending the exact required parameters

TODO

• Add test for posting to vivawallet webhook once with an additional unknown parameter, once with all given parameters and once without a given parameter

Checklist:

• [ ] I have commented my code (or ChatGPT did), particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings, neither in my IDE nor in my browser
• [ ] I have added tests that prove my fix is effective or that my feature works

[lebe1]

Hey @nanu-c, maybe you test this once in your local swagger as described above and if you think everything is fine you merge it?

[nanu-c]

I have tried it with your json on the current main and on this branch and it seems to be fixed!