augustin-wien / augustina-backend

An open-source web shop designed for selling magazines on the street.

GNU Affero General Public License v3.0

4 stars 0 forks source link

Improve middleware permission handling #134

Closed nanu-c closed 9 months ago

nanu-c commented 10 months ago

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Description

IMPORTANT TO KNOW

Each log statement should be unique, having the same log message in different places doesn't help. CHANGES

improve log messages
return 403 instead of 401 on authenticated users. The frontend tries to login on 401 but it will not help because authentications is okey but authorization fails
Fix running vendor test multiple times in a row
Add authorization tests for admin, vendor and random user
TODO

Checklist:

[x] I have commented my code (or ChatGPT did), particularly in hard-to-understand areas
[x] My changes generate no new warnings, neither in my IDE nor in my browser
[x] I have added tests that prove my fix is effective or that my feature works