augustin-wien / augustina-backend

An open-source web shop designed for selling magazines on the street.
GNU Affero General Public License v3.0
7 stars 0 forks source link

Payment model #14

Closed jofmi closed 1 year ago

jofmi commented 1 year ago

Type of change

Description

Checklist:

jofmi commented 1 year ago

Thanks for moving types to structs to have no naming confusion! I pushed two small commits. The first one due to an error I got after running docker compose build as shown below. The other commit is for the swagger. Maybe you review it now? A little inconsticency I see is our url convention as I have chosen in the beginning to use '/api/settings/' as it is shown in your collectivo API ;) But I would also prefer using '/api/payments' with no slash in the end. Do you know any conventions when to use what? The main code looks good. Especially the tests are nice! Screenshot from 2023-06-12 15-18-02

Looks good!

Regarding the slashes i think both options are fine as long as we are consistent. In Django, the solution is to accept both, but I am not sure (yet) how to implement this in this framework.