Closed jofmi closed 1 year ago
Thanks for moving types to structs to have no naming confusion! I pushed two small commits. The first one due to an error I got after running
docker compose build
as shown below. The other commit is for the swagger. Maybe you review it now? A little inconsticency I see is our url convention as I have chosen in the beginning to use '/api/settings/' as it is shown in your collectivo API ;) But I would also prefer using '/api/payments' with no slash in the end. Do you know any conventions when to use what? The main code looks good. Especially the tests are nice!
Looks good!
Regarding the slashes i think both options are fine as long as we are consistent. In Django, the solution is to accept both, but I am not sure (yet) how to implement this in this framework.
Type of change
Description
{"Payments":[{"Sender": 1, "Receiver":1, "Type":1,"Amount":1.00]}
. This can be changed once we know what information we will get from the frontend.Checklist: