Closed nanu-c closed 7 months ago
I have one final question/thought:
1. Shouldn't we add the new keycloak environment variables to our `.env.examples` like 'KEYCLOAK_CUSTOMER_GROUP' ? Besides this, I could even see the two testing versions in our keycloak GUI being created, which is really nice! :) ![image](https://private-user-images.githubusercontent.com/38591956/292177267-264428d8-2236-450c-97d7-1328b121e506.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDUzOTY4MDksIm5iZiI6MTcwNTM5NjUwOSwicGF0aCI6Ii8zODU5MTk1Ni8yOTIxNzcyNjctMjY0NDI4ZDgtMjIzNi00NTBjLTk3ZDctMTMyOGIxMjFlNTA2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTE2VDA5MTUwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg1YjNkMjUwZTdmZTI1ZjRmYTdkYmU4MTZjNjM2MzE4ZTMwNTFiODQ3NmRiYTk4YmUyZDJkZmIzYjUxODBkNTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.CRDyR1hLvekBu5SYWOfhk65AX8tCar4whrZsmTaJZMw)
maybe we should do this, but who will change it? Is it necessary that it's configurable?
I have one final question/thought:
1. Shouldn't we add the new keycloak environment variables to our `.env.examples` like 'KEYCLOAK_CUSTOMER_GROUP' ? Besides this, I could even see the two testing versions in our keycloak GUI being created, which is really nice! :) ![image](https://private-user-images.githubusercontent.com/38591956/292177267-264428d8-2236-450c-97d7-1328b121e506.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDUzOTY4MDksIm5iZiI6MTcwNTM5NjUwOSwicGF0aCI6Ii8zODU5MTk1Ni8yOTIxNzcyNjctMjY0NDI4ZDgtMjIzNi00NTBjLTk3ZDctMTMyOGIxMjFlNTA2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTE2VDA5MTUwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg1YjNkMjUwZTdmZTI1ZjRmYTdkYmU4MTZjNjM2MzE4ZTMwNTFiODQ3NmRiYTk4YmUyZDJkZmIzYjUxODBkNTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.CRDyR1hLvekBu5SYWOfhk65AX8tCar4whrZsmTaJZMw)
maybe we should do this, but who will change it? Is it necessary that it's configurable?
I don't think it is necessary that it is configurable and it also might be that this variable won't ever be changed again, which probably goes along for a few other variables in the .env.example
.
But since this variable is defined in the configs and every other variable is in the .env.example
I think by being consistent and having each variable in the .env.example
is better practice... ?
I have added an issue for this #156
Type of change
Description
IMPORTANT TO KNOW
CHANGES
Checklist: