augustin-wien / augustina-backend

An open-source web shop designed for selling magazines on the street.

GNU Affero General Public License v3.0

4 stars 0 forks source link

Add account names to payments #78

Closed lebe1 closed 12 months ago

lebe1 commented 12 months ago

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Description

IMPORTANT TO KNOW

This branch only works when we do a docker compose down -v augustin-db augustin-test-db i.e. we have to remove our databases once. Now, when a vendor is created her license-id will be used as her account name.

CHANGES

Adds SenderName to Payments and OrderEntries
Adds ReceiverName to Payments and OrderEntries
Adds Account name to accounts of type Vendor in query CreateVendor(), which is vendor's license id (and could/should be joined?)

TODO

Join license-id with vendor's account name

Checklist:

[ ] I have commented my code (or ChatGPT did), particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings, neither in my IDE nor in my browser
[ ] I have added tests that prove my fix is effective or that my feature works

jofmi commented 12 months ago

I started trying out a JOIN solution here: https://github.com/augustin-wien/augustin-backend/pull/80