search

augustinbegue / icue-ambilight

Ambilight for Corsair devices: Synchronise the colors of your iCue compatible devices with the content displayed on your screen.
Mozilla Public License 2.0
115 stars 11 forks source link

[FEATURE] Average color by applying blur to screen capture image #41

Closed chriiis78 closed 2 years ago

chriiis78 commented 3 years ago

Hello IONIS Friend 😁

This is an easy (probably not the best ?) solution to solve this request https://github.com/augustinbegue/icue-ambilight/issues/26

By applying blur to image, it smooths down the colors and avoid the colors to flicker due to a single pixel change. This effect is even more pronounced because of the small screen capture size.

The blur can be changed in Capture Previews screen, I found 4px to be a great value :

image

DJWassink commented 3 years ago

I was actually also thinking about doing something like this, cool to see someone was thinking the same 😛 However it might be cool to change it up a bit to also apply other filters? for example the translation of onscreen colors to the led colors is a bit lackluster at times, so I was thinking about maybe applying a saturate filter to amp up the colors of the captured image.

Thus this had me thinking about maybe allowing more filters, so maybe something a bit more generic? Or can we maybe somehow let users write "plugins" to modify the canvas all together? 🤔

augustinbegue commented 2 years ago

Hi!

To begin, sorry for the extreme inactivity, school is giving me a hard time to find some free time 🙃...

Thanks for your PR @chriiis78, your addition is a perfect and easy solution, I've just made a change to the layout of the page so its a bit more structured: (and also switched the input to the correct type)

image

This feature also allows the introduction of more filters as @DJWassink suggested, and I'll take a look at what I can do after I've managed to deal with the issues.

Thanks again!

Cmmdrpudintater commented 2 years ago

Thank you for creating this awesome software! I just wanted to second @DJWassink and say that a filter or some feature to increase saturation and make some colors more vibrant would be awesome. For example, in DOOM 2016 where the landscape is a deep vibrant orange, the color strip shows up as a pale white/orange color. Like wise for games with green forest scenes the light strip shows up as a pale white/green color and not vibrant. Blue scenes show up pretty well on average though! I look forward to any updates you may be able to bring!