search

augustocdias / vscode-shell-command

A task helper to use system commands as input
MIT License
51 stars 19 forks source link

Add line number variable #68

Closed MarcelRobitaille closed 11 months ago

MarcelRobitaille commented 11 months ago

Add the variable lineNumber, which is consistent with the build in VSCode variables.

bauersimon commented 9 months ago

Is this PR going to be part of a new release soon? The latest release is 1.8.2 from March 2023 and doesn't yet contain this. Would love to use it.

augustocdias commented 9 months ago

Hey... Things have been hectic at home and it can take a while until I can take a look on this... Please be patient and thanks for understanding...

I haven't released because I didn't have time to test and since my knowledge of typescript and vscode's extension dev is quite limited I didn't have time to implement proper tests...

MarcelRobitaille commented 9 months ago

Hi augustocdias. I totally understand. Until you have a bit more time, would you object to my publishing my fork as it's own extension? I can also have a look at some of the open issues here.

augustocdias commented 9 months ago

Hi augustocdias. I totally understand. Until you have a bit more time, would you object to my publishing my fork as it's own extension? I can also have a look at some of the open issues here.

No worries... You can always install from a pre built vsix package as well.

MarcelRobitaille commented 9 months ago

I published my fork here: https://marketplace.visualstudio.com/items?itemName=marcelrobitaille.tasks-shell-input-ngx. If you don't want this fork to exist, please let me know at any time.

@bauersimon 1.8.3 published there already has this lineNumber variable.

augustocdias commented 8 months ago

I don't mind. If you're willing to put some work on it I can add you as a maintainer. Especially since I see you put already some work on it. The community would benefit from a joint effort instead of 2 different extensions.

I don't have strong feelings about anything in here. I'm not a pro in TS, so I don't regard this code at a high standard. If you want to rewrite I don't really mind as well. I'm generally quite open to new features.

MarcelRobitaille commented 8 months ago

@augustocdias yes that would also work. I'm honored that you trust me enough to make me a maintainer. Shall I merge in those changes and archive the fork?

augustocdias commented 8 months ago

Yeah. Lets do that. I'll add you as a maintainer of the project.

MarcelRobitaille commented 8 months ago

Thank you very much for doing that. How does publishing work? I assume you're still the only one who can do that.

I hope you never feel any rush to reply to me. Take as much time as you need.

augustocdias commented 8 months ago

No worries. Publishing consists in just creating a new release/tag. There's a GitHub action that does that. I usually create it through GitHub's UI.

Just remember, before creating the tag, to push a commit with the new version number in the package.json and update the changelog with the new features and bug fixes. Here's an example commit:

https://github.com/augustocdias/vscode-shell-command/commit/3f3601cbb9de8dda396b04a4987a889b6cf707e5

MarcelRobitaille commented 8 months ago

Oh cool I didn't know you could do it just with tags. I thought I had to do vsce publish and somehow get an authentication token to your microsoft account. Tags is much easier.

augustocdias commented 8 months ago

Under the hood it is hahaha

The token is stored as a github secret and the action does exactly that.