augustofilocamo / superOrgan

CollaborativeOrgan
GNU General Public License v3.0
22 stars 2 forks source link

Feature request: Swell pedal AND volume control #3

Open jlearman opened 4 years ago

jlearman commented 4 years ago

First, huge kudos to you all for this excellent piece of software that was put together amazingly quickly!

As a pretty serious Hammond afficionado, I'm impressed with the sound quality and playability. I played (though never owned) a number of Hammonds starting in the 70's. For the last 15 years I've been using Native Instruments B4 and GSI VB3. If found this for a friend who wanted something inexpensive; he's a fiddle player who seconds on keyboards with a little 24-note board and laptop. So, I checked this out for his use. It's nearly good enough for stage use, but needs just a few more features to be road-worthy, without getting overblown and complicated.

Please implement the swell pedal, which is just a volume control between the organ and the Leslie. Increasing the level here causes more Leslie drive/distortion. It should be an easy trick for you guys.

By default it should respond to MIDI Expression (CC 11.) Anything would be fine for the GUI; keep it simple or have fun with it.

BTW I'm a coder but for embedded networking stuff, but if you guide me perhaps I could help (though not much with the GUI.)

Again, serious kudos for this excellent piece of work, and stay tuned for a few other requests & bug reports.

jlearman commented 4 years ago

After more experimentation, I see the knob you've labeled "volume" is actually "swell" since it is prior to the amp, and we get more drive as we press in. So just relabel it as SWELL and you're good. However, we also usually want a volume control, for practical purposes. We need this independently of the master volume for our plugin host, and don't want to have to fiddle to create one.

The volume control we would learn as CC7 (which it should be by default, as SWELL should be 11 by default.) If adding defaults, two others: Chorus is 93 and Reverb is 91.

jlearman commented 4 years ago

Another nicety: A Hammond swell pedal bottoms out to about 40%. That is, when the controller is at 0, we get about the volume CollaB3 gets with volume showing 40% (say, 11 o'clock.) Not only is this more authentic, but it provides more control in the important range.