aukedejong / lovelace-windrose-card

Home Assistant Lovelace Windrose Card
92 stars 3 forks source link

v1.6.0 breaks Sections dashboard layouts #68

Closed cryptk closed 1 month ago

cryptk commented 1 month ago

Hello, with the new 1.6.0 update my segments dashboard has some pretty bad layout issues.

If I don't specify layout_options myself, the card below this card overlaps almost half of this card.: image

When I specify:

layout_options:
  grid_columns: 4
  grid_rows: 9

The card below this card overlaps windrose card a bit, so there is no gap like all of the other cards on the dashboard. image

If I specify:

layout_options:
  grid_columns: 4
  grid_rows: 10

Now there is a gap, but it's significantly larger than the gap between the other cards image

Something with the new update is pretty severely breaking the ability for the dashboard to generate a proper layout.

aukedejong commented 1 month ago

I'll look into this. Did some quick reading. I need to implement a method with some layout details.

aukedejong commented 1 month ago

Released version 1.6.1.

This fixed it for me. I removed the method returning size information. Before this method wasn't there. Maybe I need to add it later with a correct implementation.

Thanks for opening the issue.

cryptk commented 1 month ago

Something is still very wrong. With 1.6.1, now the windrose card does not render at all, interestingly, the entire section does not render except for the heading. Additionally, the browser console is spammed with errors about uncaught promises.

Uncaught (in promise) TypeError: e is undefined
    set hass windrose-card.js:34
    value hui-card.ts:98
    value hui-card.ts:40
    value hui-section.ts:67
    _cards hui-section.ts:276
    value hui-section.ts:275
    value hui-section.ts:192
    value hui-section.ts:95
    performUpdate reactive-element.ts:1327
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    _$Eu reactive-element.ts:946
    w reactive-element.ts:931
    i hui-section.ts:37
    k scoped-custom-element-registry.js:385
    t scoped-custom-element-registry.js:236
    createElement page-script.js:191
    value hui-view.ts:111
    _sections hui-view.ts:388
    value hui-view.ts:387
    value hui-view.ts:285
    value hui-view.ts:163
    performUpdate reactive-element.ts:1327
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    _$Eu reactive-element.ts:946
    w reactive-element.ts:931
    i hui-view.ts:62
    k scoped-custom-element-registry.js:385
    t scoped-custom-element-registry.js:236
    createElement page-script.js:191
    value hui-root.ts:931
    value hui-root.ts:609
    setTimeout handler*61441/n/< render-status.ts:2
    n render-status.ts:2
    value hui-root.ts:609
    _$AE reactive-element.ts:1378
    performUpdate reactive-element.ts:1343
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    _$Eu reactive-element.ts:946
    w reactive-element.ts:931
    C lit-element.ts:115
    o hui-root.ts:112
    k scoped-custom-element-registry.js:385
    t scoped-custom-element-registry.js:236
    u lit-html.ts:1129
    g lit-html.ts:1543
    _$AI lit-html.ts:1384
    B lit-html.ts:2183
    update lit-element.ts:165
    performUpdate reactive-element.ts:1329
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    set reactive-element.ts:726
    value ha-panel-lovelace.ts:319
    value ha-panel-lovelace.ts:169
    performUpdate reactive-element.ts:1327
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    _$Eu reactive-element.ts:946
    w reactive-element.ts:931
    C lit-element.ts:115
windrose-card.js:34:135937
cryptk commented 1 month ago

Additionally, this error is given a couple of times:

Uncaught (in promise) TypeError: n is undefined
    value hui-grid-section.ts:86
    ct repeat.ts:57
    update repeat.ts:93
    _$AS directive.ts:134
    N lit-html.ts:1085
    _$AI lit-html.ts:1362
    v lit-html.ts:1192
    g lit-html.ts:1553
    _$AI lit-html.ts:1384
    B lit-html.ts:2183
    update lit-element.ts:165
    performUpdate reactive-element.ts:1329
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    _$Eu reactive-element.ts:946
    w reactive-element.ts:931
    C lit-element.ts:115
    F hui-grid-section.ts:27
    k scoped-custom-element-registry.js:385
    t scoped-custom-element-registry.js:236
    createElement page-script.js:191
    r create-element-base.ts:121
    h create-element-base.ts:279
    c create-element-base.ts:209
    E create-section-element.ts:15
    value hui-section.ts:233
    value hui-section.ts:189
    value hui-section.ts:95
    performUpdate reactive-element.ts:1327
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    _$Eu reactive-element.ts:946
    w reactive-element.ts:931
    i hui-section.ts:37
    k scoped-custom-element-registry.js:385
    t scoped-custom-element-registry.js:236
    createElement page-script.js:191
    value hui-view.ts:111
    _sections hui-view.ts:388
    value hui-view.ts:387
    value hui-view.ts:285
    value hui-view.ts:163
    performUpdate reactive-element.ts:1327
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    _$Eu reactive-element.ts:946
    w reactive-element.ts:931
    i hui-view.ts:62
    k scoped-custom-element-registry.js:385
    t scoped-custom-element-registry.js:236
    createElement page-script.js:191
    value hui-root.ts:931
    value hui-root.ts:609
    setTimeout handler*61441/n/< render-status.ts:2
    n render-status.ts:2
    value hui-root.ts:609
    _$AE reactive-element.ts:1378
hui-grid-section.ts:86:14

and then the logs continually spam with this one:

Uncaught (in promise) TypeError: n is undefined
    value hui-grid-section.ts:86
    ct repeat.ts:57
    update repeat.ts:93
    _$AS directive.ts:134
    N lit-html.ts:1085
    _$AI lit-html.ts:1362
    v lit-html.ts:1192
    g lit-html.ts:1553
    _$AI lit-html.ts:1384
    B lit-html.ts:2183
    update lit-element.ts:165
    performUpdate reactive-element.ts:1329
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    set reactive-element.ts:726
    value hui-section.ts:120
    performUpdate reactive-element.ts:1329
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    set reactive-element.ts:726
    value hui-view.ts:184
    value hui-view.ts:182
    performUpdate reactive-element.ts:1329
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    set reactive-element.ts:726
    value hui-root.ts:534
    _$AE reactive-element.ts:1378
    performUpdate reactive-element.ts:1343
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    set reactive-element.ts:726
    j lit-html.ts:1883
    _$AI lit-html.ts:1825
    v lit-html.ts:1192
    g lit-html.ts:1540
    _$AI lit-html.ts:1384
    B lit-html.ts:2183
    update lit-element.ts:165
    performUpdate reactive-element.ts:1329
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    set reactive-element.ts:726
    value partial-panel-resolver.ts:100
    value hass-router-page.ts:91
    performUpdate reactive-element.ts:1329
    scheduleUpdate reactive-element.ts:1261
    _$Ej reactive-element.ts:1233
    requestUpdate reactive-element.ts:1208
    set reactive-element.ts:726
    j lit-html.ts:1883
    _$AI lit-html.ts:1825
    v lit-html.ts:1192
    g lit-html.ts:1540
    _$AI lit-html.ts:1384
    B lit-html.ts:2183
    update lit-element.ts:165
hui-grid-section.ts:86:14
RMMTSLLP commented 1 month ago

Hi Guy's, Probably similar to whats referenced above after todays update to 1.6.1 Card does not render and shows error "Cannot read properties of undefined (reading 'state')" Card has been working fine until todays update.

RMMTSLLP commented 1 month ago

Appears to also effect the dashboard I have to now refresh a couple of times before the page renders correctly

aukedejong commented 1 month ago

Sorry, made a mistake again. Hopefully version 1.6.2 fixes it.

RMMTSLLP commented 1 month ago

Look's to be fixed just have NO wind to display here in the UK at present which is unusual. Many thanks

kdutton1964 commented 1 month ago

OK, I followed the upgrade path with issues here and there but as you hoped at least for me the final fix 1.6.2 looks fantastic thank you ever so much and it’s solved sluggishness, reload issues, etc. BTW: looks much better when you use the scaling tool to shrink 1/2 and 1/4 looks super, Great changes with the vector works. PS: I checked with iPhone, iPad, OSX, and Android tablet both with native HA apps and Safari all look consistently good. Thank You, Computer Keith

aukedejong commented 1 month ago

Good to know. Thanks. This issue is closed.