search

aullman / opentok-meet

Opentok app with screen sharing using the WebRTC screen sharing feature
MIT License
133 stars 129 forks source link

When the publisher fails you should know about it #132

Closed aullman closed 8 years ago

aullman commented 8 years ago

Right now if you get a publisher failure you don't know, the publisher just sits there. We should surface an error message if this happens.

gblachonupg commented 8 years ago

Hi, I would like to do that, could you give me some tips about where to look for.

Thank you

aullman commented 8 years ago

@gblachonupg sure. There is an "otPublisherError" you can listen for and then just surface the error.message to the user. I would suggest adding another element to the statusMessages.

aullman commented 8 years ago

@gblachonupg did you have any luck? If not I'm going to tackle this one. I had another issue today where I failed to publish and didn't notice for about 10 mins that no one in the meeting could see me.

gblachonupg commented 8 years ago

Hi,

I tried this ,

        $scope.$on('otPublisherError', function(event, error, publisher) {
          if (publisher.id !== 'screenPublisher') {
            $scope.publishError = true;
          }
        });

Added in the controller.

In my view, as you said i added a message to the statusMessage,

            <div id="publishStatus" class="statusMessage" ng-if="publishError">
                Error blablabla...
            </div>

I think it should work like this.

aullman commented 8 years ago

@gblachonupg sorry just saw your response. I already started working on a fix and it's merged in now.