search

aullman / opentok-meet

Opentok app with screen sharing using the WebRTC screen sharing feature
MIT License
133 stars 129 forks source link

publisher get stats #195

Closed aullman closed 6 years ago

aullman commented 6 years ago

See https://github.com/aullman/opentok-meet/pull/194 for details

aullman commented 6 years ago

Nice, thanks @leahciMic!

It would be good to have a simple integration test that just makes sure that when you click the button that the stats show up. Saves us doing it manually all the time. Something like: https://github.com/aullman/opentok-meet/blob/master/tests/e2e/2browserScenarios.js#L159

aullman commented 6 years ago

Also it looks like the integration tests are broken. Probably need to update the webpack loader:

IE 11.0.0 (Windows 8.1 0.0.0) ERROR
  Cannot find module "../templates/subscriber-stats.html"
  at /home/travis/build/aullman/opentok-meet/tests/unit/index.js:138028 <- webpack:///src/js/subscriber-stats.js:2:0
aullman commented 6 years ago

Oh bummer, Firefox 45 is failing because we increased the minVersion in v2.13 to 52. So there is a warning dialog that pops up in 45 that's getting in the way of clicking on things. Hence the error:

    Failed: Element is not clickable at point (85, 451.5). Other element would receive the click: <div style="display: block;" class="OT_ModalDialog"></div>
aullman commented 6 years ago

👍